[ 
https://issues.apache.org/jira/browse/QPID-7095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15214126#comment-15214126
 ] 

Rob Godfrey commented on QPID-7095:
-----------------------------------

{quote}
>From reviewing your changes I take the following:
* yes, my understanding of the intended use of {{@ManagedContextDependency}} is 
correct.
* no, the problem was not that {{doWithAllParents}} considers the type 
hierarchy instead of the model hierarchy
{quote}

Yep... The interesting thing I found when looking into the issue was that 
context defaults defined in {{Broker}} didn't seem to be being processed at 
all... I couldn't determine which change had caused this behaviour.

Separately, on your final point in your original comment:

bq. * While not being directly related to your patch I think I would like to 
see the default values for ManagedAttributes and ManagedContextDefaults in the 
ApiDocs and the MetaData.

I'm in two minds about this - at run time the default value may be overridden 
by a system property (potentially automatically overridden through packaged 
properties files) and obviously at different points in the configuration, the 
context may be overridden.  As such the "default" may be wildly misleading.

I think if we want to display the defaults somewhere, maybe there should be a 
separate page which just shows system context name -> default value or 
something.

> [Java Broker] Add meta data for context variables describing their usage
> ------------------------------------------------------------------------
>
>                 Key: QPID-7095
>                 URL: https://issues.apache.org/jira/browse/QPID-7095
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Broker
>            Reporter: Rob Godfrey
>
> Currently there is no way to discover which context variables are used by the 
> broker, and the description of what they do.  We should add meta data 
> covering this and also provide this information through the dynamic API docs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to