[ https://issues.apache.org/jira/browse/QPID-7274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15318610#comment-15318610 ]
Keith Wall commented on QPID-7274: ---------------------------------- Alex can you review the code and documentation change. > [Java Client] Asynchronous client acknowledgements > -------------------------------------------------- > > Key: QPID-7274 > URL: https://issues.apache.org/jira/browse/QPID-7274 > Project: Qpid > Issue Type: Improvement > Components: Java Client > Reporter: Jakub Scholz > Assignee: Alex Rudyy > Fix For: qpid-java-6.1 > > Attachments: sync_ack.patch > > > When the application is using client acknowledgements, they are always done > in a synchronous way with a sync() being issues after the acknowledgement. > This can have significant impact on the performance of the client > applications and it should be possible to configure the client to use > asynchronous acknowledgements. > The Java AMQP 0-10 client has already a connection URL option called > "sync_ack" which should affect whether acknowledgements are synchronous or > asynchronous, but it is used only for auto acknowledgements. It has no effect > to client acknowledgements. > Attached is a (trivial) patch which synchronizes the acknowledgements based > on the sync_ack option. It seems to work fine. However, the sync_ack option > is by default set to false. So using this option would mean that the current > behavior would change for all current applications using client > acknowledgements. I'm not sure that is desired. Would it be better to add a > new option "sync_client_ack" for the client acknowledgements which would sync > by default? Please let me know what the preferred option is and I can update > the patch. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org