[
https://issues.apache.org/jira/browse/DISPATCH-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15331754#comment-15331754
]
ASF GitHub Bot commented on DISPATCH-184:
-----------------------------------------
Github user jdanekrh commented on the issue:
https://github.com/apache/qpid-dispatch/pull/82
@ganeshmurthy What do you think about my
1. Add a Port type to python/qpid_dispatch_internal/management/schema.py,
do the conversion to int as part of validation.
2. Convert port to int in python/qpid_dispatch_internal/management/agent.py
in ListenerEntity and ConnectorEntity, either in validate, create, or init
method.
3. Catch the error code in qdpn_listener and qdpn_connector and do a if
strcmp(port, "amqp") ... there, Or call into Url.Port() in Python to avoid code
duplication.
dilemma? Is one of these preferable? I went with 2, but other may make more
sense. Or surely even other options could be suggested.
> dispatch do not stop when 'amqp' is not defined
> -----------------------------------------------
>
> Key: DISPATCH-184
> URL: https://issues.apache.org/jira/browse/DISPATCH-184
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Container
> Environment: Gentoo linux, Linux falka 4.2.3-gentoo #1 SMP Thu Oct 8
> 10:08:43 CEST 2015 x86_64 Intel(R) Core(TM) i7-4600U CPU @ 2.10GHz
> GenuineIntel GNU/Linux
> proton-c (latest from apache github a16c58a59c2a5504ecd556dd397b7d28cc68dbd4)
> dispatch (latest from apache github 8353ac674a7150a1bbfa63c912ad9689a492e84a)
> sys-devel/gcc-4.9.3
> dev-lang/python-2.7.10
> Reporter: Zdenek Kraus
> Priority: Minor
> Attachments: python_qdstat-g_fc23.stacktrace
>
>
> If there is no existent record of 'amqp' protocol being 5672/tcp in
> /etc/services, dispatch logs error messages and continue on.
> steps:
> 1. make sure that record 'amqp 5672/tcp' is not present at /etc/services
> 2. run qpid dispatch
> current results:
> Wed Oct 21 16:11:35 2015 DRIVER (error) getaddrinfo(0.0.0.0, amqp): Servname
> not supported for ai_socktype
> and continue.
> expected:
> error message and should stop with error.
> note: this could be added into documentation
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
