Github user alanconway commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/83#discussion_r68114202
--- Diff: python/qpid_dispatch_internal/tools/command.py ---
@@ -83,6 +83,11 @@ def connection_options(options, title="Connection
Options"):
help="Trusted Certificate Authority Database file
(PEM Format)")
group.add_option("--ssl-password", action="store", type="string",
metavar="PASSWORD",
help="Certificate password, will be prompted if not
specifed.")
+ group.add_option("--no-verify-host-name", action="store_true",
default=False,
--- End diff --
I'd suggest: --verify-peer-name type=bool, default=true. Bool options with
negative names are confusing and "host" is a bit vague - peer is more clearly
the _other_ host. Also the help text is very long, maybe "Verify the peer host
name matches the certificate. Default true, setting to false is insecure ."
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
