[ 
https://issues.apache.org/jira/browse/QPID-7306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15345122#comment-15345122
 ] 

ASF subversion and git services commented on QPID-7306:
-------------------------------------------------------

Commit 1749780 from [~aconway] in branch 'qpid/trunk'
[ https://svn.apache.org/r1749780 ]

QPID-7306: Memory management error in Link/Bridge

qpid::broker Link and Bridge use Connection::requestIOProcessing() to register
callbacks in the connection thread. They were binding a plain "this" pointer to
the callback, but the classes are managed by boost::shared_ptr so if all the
shared_ptr were released, the callback could happen on a dangling pointer.

This fix uses boost::weak_ptr in the callbacks, so if all shared_ptr instances
are released, we don't use the dead pointer.

Link::destroy cannot be skipped, so use a shared_ptr for that.

> Fix memory bugs and race conditions found in a Qpid HA deployment
> -----------------------------------------------------------------
>
>                 Key: QPID-7306
>                 URL: https://issues.apache.org/jira/browse/QPID-7306
>             Project: Qpid
>          Issue Type: Bug
>          Components: C++ Broker
>    Affects Versions: 0.32
>            Reporter: Alan Conway
>            Assignee: Alan Conway
>
> Bugs related to thread safety and lifecycle of Links/Bridges, management 
> objects and Queues. These were discovered in a HA environment but most of the 
> issues could theoretically affect a stand alone broker also. For more 
> information see https://bugzilla.redhat.com/show_bug.cgi?id=1333767



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to