Github user mbroadst commented on a diff in the pull request:

    https://github.com/apache/qpid/pull/9#discussion_r68322985
  
    --- Diff: qpid/cpp/src/qpid/broker/amqp/Outgoing.cpp ---
    @@ -79,6 +79,9 @@ OutgoingFromQueue::OutgoingFromQueue(Broker& broker, 
const std::string& source,
     
     void OutgoingFromQueue::init()
     {
    +    // observe queue for changes to track undeliverable messages
    +    
queue->getObservers().add(boost::shared_ptr<QueueObserver>(shared_from_this()));
    +
    --- End diff --
    
    I wondered about that. From other examples of QueueObserver's in the 
codebase I didn't see anything that explicitly removed itself from the observer 
list, so assumed (dangerously/lazily 😄) it was cleaned up automatically 
somewhere. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to