Github user grs commented on a diff in the pull request: https://github.com/apache/qpid/pull/10#discussion_r68769620 --- Diff: qpid/cpp/src/qpid/broker/amqp/Outgoing.cpp --- @@ -108,6 +109,19 @@ void OutgoingFromQueue::write(const char* data, size_t size) pn_link_send(link, data, size); } +void OutgoingFromQueue::maybeMergeMessageAnnotations(const Record &r) --- End diff -- Minor, subjective point on the method name: 'maybe' sounds vague, perhaps mergeAnnotationsIfRequired? or checkAndMergeAnnotations? Change looks good though, thanks again!
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org