[
https://issues.apache.org/jira/browse/QPID-7248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15372509#comment-15372509
]
Alex Rudyy commented on QPID-7248:
----------------------------------
Keith,
I reviewed the changes made in commits
[r1751940|https://svn.apache.org/r1751940],
[r1751916|https://svn.apache.org/r1751916],
[r1751884|https://svn.apache.org/r1751884],
[r1751879|https://svn.apache.org/r1751879],
[r1751816|https://svn.apache.org/r1751816],
[r1751800|https://svn.apache.org/r1751800],
[r1751799|https://svn.apache.org/r1751799] and
[r1751782|https://svn.apache.org/r1751782]. Here are my comments:
* QueryBrowserWidget comments
** Queue browser tree table flushes yellow on changes
** Filter toolbar does not stretch through entire tab width
** Methods "transformer" and "processPreferencesForObject" (which are passed as
arguments into store constructor) operates with store state variables. IMHO, it
would be more correct to move them into PreferencesStore class rather then
mixin into store via constructor.
** Field management is declared twice in QueryBrowserWidget
** I am not sure about displaying of "No data" messages in dgrid in container
for rows. Whouldn't it be better to hide the grid and display the div with a
message instead?
* Structure
** structure is retrieved twice at the moment (as part of treeView and via
controller structure updater). Treeview can re-use the structure data
** unrequired "coma" in import at line 21
** missing semicolums at lines 69 and 73
* QueryWidget
** QuerySaveDialogForm#_onChange contains a dead code. It used to disable Save
button if name is not entered. The disabling functionality has been removed.
Was it intentional? Imho disabling of button gives a better user experience
** on change events are still emitted when no change happens
** Indication about changes in query via "*" suffix on query tab title is
broken:
*** Star prefix is added to the Query tab title unexpextedly whilst navigating
(with keyborad or mouse) through controls in advanced view. It gives false
imression that query is changed
*** Star prefix is not added to the Query tab title after query changes in
following cases
**** when value of advanced control is changed and Enter is pressed
**** when page size is changed
**** after navigation to another page
*** Star prefix is not removed from the Query tab title when query is changed
back to its original value
> Extend the UI to allow queries to be saved, retrieved and re-run
> ----------------------------------------------------------------
>
> Key: QPID-7248
> URL: https://issues.apache.org/jira/browse/QPID-7248
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Reporter: Keith Wall
> Fix For: qpid-java-6.1
>
> Attachments:
> 0001-QPID-7248-Java-Broker-Preferences-show-preferences-b.patch,
> extend-query-ui-to-allow-queries-to-be-saved.tar.gz,
> query-browser-patches.tar.gz
>
>
> Extend the UI to allow the user to save a query so that it is available for
> use later on. The user should be able to see a list of saved queries, pick
> one and rerun it or change it. The user should be able to delete queries too.
> The user should also be able to see queries that are visible to him. He
> should be able to select these queries and execute them.
> * When defining a query, the UI should offer a 'save as' button allowing the
> query to be named, visibility to be chosen, and saved.
> * If the query has been saved already, the name should be filled in already.
> * Saved queries and queries that are visible to the user will appear to the
> user as a list (expandable/collapsible widget)
> * From the list the user will be able to delete queries that belong to him.
> * Also from the list, the user will be able to recall queries (either queries
> that belong to him or ones that are visible). The query will be recalled in
> the advanced
> view, even if the query is representable in standard view.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
