[ 
https://issues.apache.org/jira/browse/PROTON-1164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15392231#comment-15392231
 ] 

Andrew Stitcher commented on PROTON-1164:
-----------------------------------------

We can resolve this issue but there are still some unimplemented link event 
handlers:
* on_receiver_detach
* on_sender_detach
So we should open a specific issue to track these handlers.

There are 2 handlers that have different names in the documentation and the 
code:
* on_sender_flush_start (the code has on_sender_drain_start)
* on_receiver_flush_finish (the code has on_receiver_drain_finish)

I don't know which should be fixed, again probably an issue.

> Update handlers to align with current proposal
> ----------------------------------------------
>
>                 Key: PROTON-1164
>                 URL: https://issues.apache.org/jira/browse/PROTON-1164
>             Project: Qpid Proton
>          Issue Type: Improvement
>          Components: cpp-binding
>            Reporter: Andrew Stitcher
>            Assignee: Andrew Stitcher
>
> The current event handler proposal includes the primary object that the event 
> is concerned with in the handler signature. This makes it more convenient to 
> process the event by giving the most likely object to be needed directly to 
> the handler without any other lookups.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to