[
https://issues.apache.org/jira/browse/QPID-7318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15404319#comment-15404319
]
Rob Godfrey commented on QPID-7318:
-----------------------------------
h4. Patch 10 (Auto-generate acl checking for managed operations)
{quote}
* {{ConfiguredObjectFactoryGenerator#processManagedOperation}} starts with a
semicolon
{quote}
Fixed
{quote}
* It might be just me but I find this idiom ugly (and it is all over
{{ConfiguredObjectFactoryGenerator}}:{code}boolean first = true;
for(VariableElement param : methodElement.getParameters())
{
if (first)
{
first = false;
}
else
{
pw.print("\", \"");
}
pw.print(getParamName(param));
}{code} Unfortunately the only alternative I see in Java 7 is something like
this:{code}String s = Joiner.on("\",
\"").join(Iterables.transform(methodElement.getParameters(), new
Function<String, String>()
{
@Override
public String apply(final String input)
{
return input.toLowerCase();
}
}));
pw.print(s);{code} Not sure it is worth changing. Probably not.
{quote}
Yeah - given it's in code generation code I'm not inclined to try to make it
any prettier.
h4. Patch 13
{quote}
* (VH-)AccessControllProvider#getPriority is missing description
{quote}
fixed
> [Java Broker] Refactor existing ACL plugin code
> -----------------------------------------------
>
> Key: QPID-7318
> URL: https://issues.apache.org/jira/browse/QPID-7318
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Reporter: Rob Godfrey
> Assignee: Rob Godfrey
> Fix For: qpid-java-6.1
>
>
> While the aim is to redesign the ACL implementation in the v6.2 or v7.0
> timeframe, there is still utility in tidying up the existing ACL
> implementation a bit. In particular by separating out functions and
> providing a better encapsulation, we will make the job of writing automated
> upgraders to any new ACL implementation substantially easier.
> As a first step we can separate out the parsing of the ACL file, from the
> "rule based" implementation of ACLs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
