> On Aug. 4, 2016, 2:57 p.m., Andrew Stitcher wrote: > > src/qpid/sys/epoll/EpollPoller.cpp, line 573 > > <https://reviews.apache.org/r/50759/diff/2/?file=1462305#file1462305line573> > > > > Tiny quibble: > > > > Could be > > > > if (now_ >= targetTimeout) ... > > Cliff Jansen wrote: > I tried that first! There is no >= operator in AbsTime.
Oh, I hadn't thought of that! I'd be inclined to add it in that case - typically the operators have been lazy created as to need rather than trying to attempt jewel like perfection first time! [Incidentally I'm now regretting not having AbsTime operator+(AbsTime, Duration) as it would have made some of this code clearer too! Mea culpa] - Andrew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50759/#review144765 ----------------------------------------------------------- On Aug. 4, 2016, 3:32 a.m., Cliff Jansen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50759/ > ----------------------------------------------------------- > > (Updated Aug. 4, 2016, 3:32 a.m.) > > > Review request for qpid and Andrew Stitcher. > > > Bugs: qpid-7373 > https://issues.apache.org/jira/browse/qpid-7373 > > > Repository: qpid-cpp > > > Description > ------- > > If a C++ broker is lightly loaded with many short lived connections such that > at least one worker thread remains unwoken from the epoll_wait, its > DeletionManager::ThreadStatus::handles grows without bound and the associated > handles retain a shared_ptr ref and never go away. > > This patch allows IO threads a maximum of one minute to accumulate > DeletionManager shared pointer references before resuming the wait loop which > involves calling > > PollerHandleDeletionManager.markAllUnusedInThisThread(); > > The overhead is small on brokers light thread load and non-existent on busy > brokers. > > > Diffs > ----- > > src/qpid/sys/epoll/EpollPoller.cpp 6fdf996 > > Diff: https://reviews.apache.org/r/50759/diff/ > > > Testing > ------- > > Jira test case, PollerTest.cpp > > > Thanks, > > Cliff Jansen > >
