[
https://issues.apache.org/jira/browse/QPID-7413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15458446#comment-15458446
]
Lorenz Quack commented on QPID-7413:
------------------------------------
Sorry Alex, but I do have a couple more comments:
* The clone dialogue for queries still has the old wording for scope
* In the tooltip for scope in the query creation dialogue: {{Determines where
query is stored and where to query for the objects.}} should be {{Determines
where *the* query is stored and where to query for the objects.}}
* The stars after the labels (indicating the fields as mandatory) in the
dialogues are a bit pointless since you cannot leave the combo box empty. But I
am not opposed to leaving them for consistency.
* In {{PreferenceBrowserWidget#_renderGroups}} you successively build up a
string using the += operator in addition you have a if check to only insert
between elements and not at the very end. This is exactly the pattern that
{{array.join(separator)}} is for. You do not need the if logic and it can be
more efficient because it does not have to create N successively larger
immutable strings (e.g. by use something like a Java stringbuilder).
* In {{PreferenceBrowserWidget#_renderOwner}} you check twice for {{value}}
once hidden in the ternary operator and once in the explicit if-statement. This
could all move into one if block
> [Java Broker, WMC] Fix minor defects and usability issues in query and
> dashboard UI
> -----------------------------------------------------------------------------------
>
> Key: QPID-7413
> URL: https://issues.apache.org/jira/browse/QPID-7413
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: qpid-java-6.0.1
> Reporter: Alex Rudyy
> Assignee: Alex Rudyy
> Fix For: qpid-java-6.1
>
>
> # Menu bar - the serialized form of the username in the menu bar looks ugly
> # Menu bar is a muddle of some with icons some with text and some with both.
> We said all menu titles would have a word and icon. We said menu entries
> would not have an icon.
> # Rename Show Xxxxxxx Browser => Browse Xxxxxx
> # Add explanatory text to the Create Query and Create Dashboard dialogues to
> help the user understand what scope and category mean.
> # In the save dialogues, the fully qualified name of the group should be
> visible to the user, perhaps as a hover.
> # A newly cloned query does not warn if it is closed before save has been
> pressed.
> # Use qpid confirmation dialogue box instead of system confirmation dialogue
> universally
> # On the Query and Dashboard browsers rename "Mine" to "Created by me"
> # Add the ability select a query from the query browser with the Return key.
> # Add an icon to the "Add Widget" button
> # Add units to the refresh period in the widget customization dialogue
> # Defect: With a group of HA nodes, create a virtualhost scoped dashboard
> containing a virtualhost scoped query, Flip the mastership Expected
> behaviour - dashboard and widget should be present on the new master.
> Actual: dashboard was present but was empty.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
