----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51638/#review149721 -----------------------------------------------------------
Ship it! I won't argue with that :) - Alan Conway On Sept. 20, 2016, 6:56 p.m., Gordon Sim wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51638/ > ----------------------------------------------------------- > > (Updated Sept. 20, 2016, 6:56 p.m.) > > > Review request for qpid and Alan Conway. > > > Repository: qpid-cpp > > > Description > ------- > > Introduces two new connection options (AMQP 1.0 only): > > * max_delivery_count determines how many times we try to resend a 'released' > message. A value of 0, which is the default, retries indefinitely. > * raise_rejected determines whether an MessageRejected exception is raised > when a message is 'rejected', the default is true > > A message is considered 'released' if the outcome is relased, or if the > outcome as modified and the 'undeliverable-here' flag is not set. A message > is considered 'rejected' if the outcome is rejected, if the outcome is > modified *and* the 'undeliverable-here' flag is set, or if it was 'released' > but we have reached the maximum nuber of delivery attempts. > > Original behaviour can be obtained by setting max_delivery_count=1 and > raise_rejected=false. > > > Diffs > ----- > > src/qpid/messaging/ConnectionOptions.h 6b89838 > src/qpid/messaging/ConnectionOptions.cpp 3095169 > src/qpid/messaging/amqp/ConnectionContext.cpp ff6a7be > src/qpid/messaging/amqp/EncodedMessage.cpp cf60046 > src/qpid/messaging/amqp/SenderContext.h 467a8e0 > src/qpid/messaging/amqp/SenderContext.cpp fe8b4d3 > src/qpid/messaging/amqp/SessionContext.h 67b3c1e > src/qpid/messaging/amqp/SessionContext.cpp 92bdea7 > src/qpid/messaging/amqp/Transaction.cpp 754b00d > > Diff: https://reviews.apache.org/r/51638/diff/ > > > Testing > ------- > > > Thanks, > > Gordon Sim > >
