[
https://issues.apache.org/jira/browse/QPID-7433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15536405#comment-15536405
]
Alex Rudyy commented on QPID-7433:
----------------------------------
Keith,
I reviewed the changes but did not run TCK yet. The code and configuration look
Ok to me but I have to picky comments:
* I am wondering whether hard-coded username and password (in
ManageQpidJMSResources) could be potentially flagged by such scanning tools
like DEI as security issue?
I think that we need to stop hardcoding credentials.
* the sub-module is called "qpid-tck" which could be interpreted as Qpid
implementation of Technology Compatibility Kit. Perhaps, in future there will
be such kit to test AMQP interoperability. I think that more correct name for
the module would be "qpid-tck-runner" or "qpid-tck-invoker".
Apart from above I have no other comments
> Add minimal maven module to invoke TCK
> --------------------------------------
>
> Key: QPID-7433
> URL: https://issues.apache.org/jira/browse/QPID-7433
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker, Java Tests
> Reporter: Keith Wall
> Assignee: Keith Wall
> Priority: Minor
> Fix For: qpid-java-6.1
>
> Attachments: 0001-wip-working.patch
>
>
> Add a miminal maven module to the Java build, rather like the Joram one,
> that allows the TCK to be run against the Qpid JMS client and the legacy
> client too against a pre-running Broker. The TCK is proprietary. The
> caller will need to provide the TCK himself.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
