Github user ChugR commented on a diff in the pull request:

    https://github.com/apache/qpid-dispatch/pull/106#discussion_r81838943
  
    --- Diff: include/qpid/dispatch/server.h ---
    @@ -418,6 +418,22 @@ typedef struct qd_server_config_t {
         uint32_t max_frame_size;
     
         /**
    +     * The max_sessions value is the number of sessions allowed on the 
Connection. 
    +     * This value minus one is the Open performative channel-max setting.
    +     */
    +    uint32_t max_sessions;
    +
    +    /**
    +     * The max_session_window value is the maximum number of outstanding 
octets that are
    --- End diff --
    
    Good suggestion. The setting down to proton would be <this setting value> * 
max-frame-size octets.
    There is an identical setting in policy that operates this way, too. Again, 
they ought to be the same either way.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to