[ 
https://issues.apache.org/jira/browse/QPID-7477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15628782#comment-15628782
 ] 

Keith Wall edited comment on QPID-7477 at 11/2/16 12:29 PM:
------------------------------------------------------------

I think we need to change the existing PrincipalAccessor into an 
SubjectAccessor.  The TaskExecutor will merely use the returned subject from 
the SubjectAccessor  when elevating permissions (Subject.doAs).   For the 
SystemLaucher, it needs to provide a SubjectAccessor that always simply returns 
the (readonly) org.apache.qpid.server.SystemLauncher#_brokerTaskSubject.   For 
AVH, it needs to produce a subject in the same way as today i.e. take the 
calling context and add the VH principal.




was (Author: k-wall):
I think we need to change the existing PrincipalAccessor into an 
SubjectAccessor.  The TaskExecutor will merely use the returned subject from 
the SubjectAccessor  when elevating permissions (Subject.doAs).   For the 
SystemLaucher, it needs to provide a SubjectAccessor that always simply returns 
the (readonly) org.apache.qpid.server.SystemLauncher#_brokerTaskSubject.   For 
AVH, it needs to produce a subject in the same way as today i.e. take the 
calling context and add the VH principal.

> [Java Broker] Recovery of Broker preferences should happen without holding 
> VirtualHostPrincipal
> -----------------------------------------------------------------------------------------------
>
>                 Key: QPID-7477
>                 URL: https://issues.apache.org/jira/browse/QPID-7477
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>    Affects Versions: qpid-java-6.1
>            Reporter: Lorenz Quack
>             Fix For: qpid-java-6.1, qpid-java-6.2
>
>
> If a {{VirtualHostLogger}} is configured it will log the recovery of Broker 
> preferences on the Broker-Config thread. It should not do this.
> The cause seems to be that during execution of 
> {{BrokerImpl#performActivation}} the {{Subject}} contains the 
> {{VirtualHostPrincipal}}.
> I think this is related to the fact that the call stack shows that this code 
> is called from the {{onSuccess}} callback of {{VirtualHostNode#doActivation}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to