Github user astitcher commented on the issue:

    https://github.com/apache/qpid-proton/pull/85
  
    A couple of comments:
    
    * It seems entirely arbitrary (to me anyway) to move generating encoding.h 
and protocol.h from the C build process to generating them when producing the C 
part of the python install. We know that we have python available at the time 
of build the C code (well duh!) so we could keep on generating at C build time 
when we do the python install.
    
    This seems to me to minimise the divergence between the packaged C source 
for the python package and the real C source tree.
    
    * Given the c code built by the python install is somewhat selective anyway 
- it makes sense (again to me anyway) only to package C source which is 
actually used in the library used by the python installation.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to