Github user ted-ross commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/109#discussion_r87850131
--- Diff: src/log.c ---
@@ -355,6 +358,14 @@ bool qd_log_enabled(qd_log_source_t *source,
qd_log_level_t level) {
void qd_log_impl(qd_log_source_t *source, qd_log_level_t level, const char
*file, int line, const char *fmt, ...)
{
+ /*-----------------------------------------------
+ Count this log-event in this log's histogram
+ whether or not this log is currently enabled.
+ We can always decide not to look at it later,
+ based on its used/unused status.
+ -----------------------------------------------*/
+ source->severity_histogram [ level ] ++;
--- End diff --
You have a type problem here. qd_log_level_t can't be used as an index
into an array since it is a bitmask.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
