[ 
https://issues.apache.org/jira/browse/DISPATCH-596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15751662#comment-15751662
 ] 

ASF GitHub Bot commented on DISPATCH-596:
-----------------------------------------

GitHub user ganeshmurthy opened a pull request:

    https://github.com/apache/qpid-dispatch/pull/127

    DISPATCH-596 - Preserve the error from the rejected state in relayed …

    …disposition

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-596

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/qpid-dispatch/pull/127.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #127
    
----
commit 01461e4ebb4b40fe3862a528e5b77493128ad315
Author: Ganesh Murthy <gmur...@redhat.com>
Date:   2016-12-15T15:29:44Z

    DISPATCH-596 - Preserve the error from the rejected state in relayed 
disposition

----


> error is lost from rejected state in relayed disposition
> --------------------------------------------------------
>
>                 Key: DISPATCH-596
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-596
>             Project: Qpid Dispatch
>          Issue Type: Bug
>    Affects Versions: 0.7.0
>            Reporter: Gordon Sim
>            Assignee: Ganesh Murthy
>             Fix For: 0.8.0
>
>         Attachments: reject.py
>
>
> {noformat}
> [0x55d7cde663a0]:  -> SASL
> [0x55d7cde663a0]:  <- SASL
> [0x55d7cde663a0]:0 <- @sasl-mechanisms(64) 
> [sasl-server-mechanisms=@PN_SYMBOL[:ANONYMOUS]]
> [0x55d7cde663a0]:0 -> @sasl-init(65) [mechanism=:ANONYMOUS, 
> initial-response=b"anonymous@localhost.localdomain"]
> [0x55d7cde663a0]:0 <- @sasl-outcome(68) [code=0]
> [0x55d7cde663a0]:  -> AMQP
> [0x55d7cde663a0]:0 -> @open(16) 
> [container-id="4308de22-4121-49bc-bac4-8ee05bf1504e", hostname="localhost", 
> channel-max=32767]
> [0x55d7cde663a0]:0 -> @begin(17) [next-outgoing-id=0, 
> incoming-window=2147483647, outgoing-window=2147483647]
> [0x55d7cde663a0]:0 -> @attach(18) 
> [name="4308de22-4121-49bc-bac4-8ee05bf1504e-examples", handle=0, role=true, 
> snd-settle-mode=2, rcv-settle-mode=0, source=@source(40) [address="examples", 
> durable=0, timeout=0, dynamic=false], target=@target(41) [durable=0, 
> timeout=0, dynamic=false], initial-delivery-count=0]
> [0x55d7cde663a0]:0 -> @attach(18) 
> [name="4308de22-4121-49bc-bac4-8ee05bf1504e-examples", handle=1, role=false, 
> snd-settle-mode=2, rcv-settle-mode=0, source=@source(40) [durable=0, 
> timeout=0, dynamic=false], target=@target(41) [address="examples", durable=0, 
> timeout=0, dynamic=false], initial-delivery-count=0]
> [0x55d7cde663a0]:0 -> @flow(19) [incoming-window=2147483647, 
> next-outgoing-id=0, outgoing-window=2147483647, handle=0, delivery-count=0, 
> link-credit=10, drain=false]
> [0x55d7cde663a0]:  <- AMQP
> [0x55d7cde663a0]:0 <- @open(16) [container-id="Router.A", 
> max-frame-size=16384, channel-max=32767, idle-time-out=8000, 
> offered-capabilities=:"ANONYMOUS-RELAY", 
> properties={:product="qpid-dispatch-router", :version="0.8.0"}]
> [0x55d7cde663a0]:0 <- @begin(17) [remote-channel=0, next-outgoing-id=0, 
> incoming-window=100, outgoing-window=2147483647]
> [0x55d7cde663a0]:0 <- @attach(18) 
> [name="4308de22-4121-49bc-bac4-8ee05bf1504e-examples", handle=0, role=false, 
> snd-settle-mode=2, rcv-settle-mode=0, source=@source(40) [address="examples", 
> durable=0, timeout=0, dynamic=false], target=@target(41) [durable=0, 
> timeout=0, dynamic=false], initial-delivery-count=0]
> [0x55d7cde663a0]:0 <- @attach(18) 
> [name="4308de22-4121-49bc-bac4-8ee05bf1504e-examples", handle=1, role=true, 
> snd-settle-mode=2, rcv-settle-mode=0, source=@source(40) [durable=0, 
> timeout=0, dynamic=false], target=@target(41) [address="examples", durable=0, 
> timeout=0, dynamic=false], initial-delivery-count=0]
> [0x55d7cde663a0]:0 <- @flow(19) [next-incoming-id=0, incoming-window=100, 
> next-outgoing-id=0, outgoing-window=2147483647, handle=1, delivery-count=0, 
> link-credit=250, drain=false]
> [0x55d7cde663a0]:0 -> @transfer(20) [handle=1, delivery-id=0, 
> delivery-tag=b"1", message-format=0, settled=false, more=false] (78) 
> "\x00Sp\xd0\x00\x00\x00\x0b\x00\x00\x00\x05BP\x04@BR\x00\x00Ss\xd0\x00\x00\x00"\x00\x00\x00\x0d@@@@@@@@\x83\x00\x00\x00\x00\x00\x00\x00\x00\x83\x00\x00\x00\x00\x00\x00\x00\x00@R\x00@\x00Sw\xa1\x0cHello
>  World!"
> [0x55d7cde663a0]:0 <- @transfer(20) [handle=0, delivery-id=0, 
> delivery-tag=b"\x07\x00\x00\x00\x00\x00\x00\x00", message-format=0, 
> settled=false, more=false] (78) 
> "\x00Sp\xd0\x00\x00\x00\x0b\x00\x00\x00\x05BP\x04@BR\x00\x00Ss\xd0\x00\x00\x00"\x00\x00\x00\x0d@@@@@@@@\x83\x00\x00\x00\x00\x00\x00\x00\x00\x83\x00\x00\x00\x00\x00\x00\x00\x00@R\x00@\x00Sw\xa1\x0cHello
>  World!"
> Rejecting delivery: Hello World!
> [0x55d7cde663a0]:0 -> @disposition(21) [role=true, first=0, last=0, 
> settled=true, state=@rejected(37) [error=@error(29) 
> [condition=:"amqp:internal-error", description="you were out of luck this 
> time!"]]]
> receiver sends disposition with rejected containing and error...
> [0x55d7cde663a0]:0 <- @flow(19) [next-incoming-id=1, incoming-window=100, 
> next-outgoing-id=1, outgoing-window=2147483647, handle=1, delivery-count=1, 
> link-credit=250, drain=false]
> [0x55d7cde663a0]:0 <- @disposition(21) [role=true, first=0, last=0, 
> settled=true, state=@rejected(37) []]
> Message was rejected: None
> disposition that gets relayed back to sender no longer has the error 
> information
> [0x55d7cde663a0]:0 -> @close(24) []
> [0x55d7cde663a0]:  -> EOS
> [0x55d7cde663a0]:0 <- @close(24) []
> [0x55d7cde663a0]:  <- EOS
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to