[
https://issues.apache.org/jira/browse/QPID-7555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15785731#comment-15785731
]
Alex Rudyy commented on QPID-7555:
----------------------------------
The implemented changes look good to me. They improve and simplify the
perftests startup. However, I have 2 comments about changes:
* I believe that having 2 profiles (jms-client-0-9 and jms-client-0-10) for
legacy jms client is redundant. Instead, I would have only one profile (called,
for instance, legacy-jms-client) where amqp version is set to 0.10 by default.
The caller would simply need to override the desired amqp version through a JVM
property {{qpid.amqp.version}}
* The execution of perftests is happening in life-cycle stage
"integration-tests". When running performance tests the module unit tests are
executed as well (unless option -DskipTests is specified). I think that unit
tests can be skipped if perftests profile is activated by adding into perftests
profile the following
{code}
Index: perftests/pom.xml
===================================================================
--- perftests/pom.xml (revision 1776396)
+++ perftests/pom.xml (working copy)
@@ -314,6 +314,13 @@
</execution>
</executions>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <configuration>
+ <skip>true</skip>
+ </configuration>
+ </plugin>
</plugins>
</build>
</profile>
{code}
> Improve performance-test maven pom to allow the convenient running of
> performance tests from Maven
> --------------------------------------------------------------------------------------------------
>
> Key: QPID-7555
> URL: https://issues.apache.org/jira/browse/QPID-7555
> Project: Qpid
> Issue Type: Improvement
> Components: Java Performance Tests
> Reporter: Keith Wall
> Assignee: Keith Wall
> Priority: Minor
>
> Improve performance-test maven pom to allow the convenient running of
> performance tests from Maven, against both AMQP Qpid 1.0 client and the
> Legacy Client.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
