Github user ted-ross commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/134#discussion_r94648607
--- Diff: tests/system_tests_three_routers.py ---
@@ -220,6 +225,70 @@ def run(self):
Container(self).run()
+class DynamicRequestResponseTest(MessagingHandler):
+ def __init__(self, address1, address2):
+ super(DynamicRequestResponseTest, self).__init__(prefetch=0)
+ self.address1 = address1
+ self.address2 = address2
+ self.dest = "closest.dynamicRequestResponse"
+ self.error = None
+ self.sender = None
+ self.server_receiver = None
+ self.client_receiver = None
+ self.n_expected = 10
+ self.n_sent = 0
+ self.n_received = 0
+ self.n_accepted = 0
+
+ def timeout(self):
+ self.error = "Timeout Expired %d messages received." %
self.n_received
+ self.client_connection.close()
+ self.server_connection.close()
+
+ def on_released(self, event):
+ self.n_sent -= 1
+ time.sleep(0.1)
+
+ def on_start(self, event):
+ self.timer = event.reactor.schedule(5, Timeout(self))
+ self.client_connection = event.container.connect(self.address1)
+ self.server_connection = event.container.connect(self.address2)
+ self.server_receiver =
event.container.create_receiver(self.server_connection, self.dest)
+ self.client_receiver =
event.container.create_receiver(self.client_connection, None, dynamic=True)
+ self.server_receiver.flow(self.n_expected)
+ self.client_receiver.flow(self.n_expected)
+ self.sender =
event.container.create_sender(self.client_connection, None)
+
+ def on_sendable(self, event):
+ if self.n_sent < self.n_expected:
+ # We send to server, and ask it to reply to client.
+ request = Message(body=self.n_sent, address=self.dest,
reply_to=self.client_receiver.remote_source.address)
--- End diff --
There's a race condition here. What if you get credit on the sender before
the dynamic receiver is fully attached?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
