Github user cliffjansen commented on a diff in the pull request:

    https://github.com/apache/qpid-proton/pull/93#discussion_r95450710
  
    --- Diff: proton-c/bindings/python/proton/__init__.py ---
    @@ -2581,6 +2581,9 @@ def close(self):
         """
         self._update_cond()
         pn_connection_close(self._impl)
    +    if hasattr(self, '_session_policy'):
    --- End diff --
    
    Before my delta, the existing use of the attribute was via a hasattr() 
test.  Elsewhere in the code, hasattr attributes seemed to be decommissioned 
via del instead of None (more pythonic?). Functionally I have no preference 
between the two.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to