[ 
https://issues.apache.org/jira/browse/PROTON-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15825576#comment-15825576
 ] 

Andrew Stitcher commented on PROTON-1381:
-----------------------------------------

I've tried to apply this patch to master and failed.

{{DH_set0_pqg()}} is not declared:

{noformat}
../proton-c/src/ssl/openssl.c: In function ‘get_dh2048’:
../proton-c/src/ssl/openssl.c:399:11: error: implicit declaration of function 
‘DH_set0_pqg’ [-Wimplicit-function-declaration]
       || !DH_set0_pqg(dh, dhp_bn, NULL, dhg_bn)) {
           ^~~~~~~~~~~
{noformat}

My development box has openssl 1.0.2j (Fedora 25)

In fact the openssl manpage at 
https://www.openssl.org/docs/man1.1.0/crypto/DH_get0_pqg.html says that this 
was introduced in openssl 1.1.0.

So I think you must have made some mistake when you verified with earlier 
versions of openssl.

I'd very much like to get this issue fixed, but I can't commit a change that 
won't work with current versions of openssl too.

> Compiler errors: dereferencing pointer to incomplete type DH {aka struct 
> dh_st}
> -------------------------------------------------------------------------------
>
>                 Key: PROTON-1381
>                 URL: https://issues.apache.org/jira/browse/PROTON-1381
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: proton-c
>    Affects Versions: 0.14.0, 0.16.0
>         Environment: GCC 6.2.1, OpenSSL 1.1.0c
>            Reporter: Volker Diels-Grabsch
>            Assignee: Andrew Stitcher
>            Priority: Blocker
>              Labels: build, patch
>         Attachments: 
> qpid-proton-0.14.0-fix-dereferencing-pointer-to-incomplete-type.patch
>
>
> Proton-C doesn't build with GCC 6.2.1 and OpenSSL 1.1.0c. The error message 
> is:
> {code:borderStyle=solid}
> [ 51%] Building C object 
> proton-c/CMakeFiles/qpid-proton.dir/src/ssl/openssl.c.o
> /.../proton-c/src/ssl/openssl.c: In function ‘get_dh2048’:
> /.../proton-c/src/ssl/openssl.c:406:5: error: dereferencing pointer to 
> incomplete type ‘DH {aka struct dh_st}’
>    dh->p=BN_bin2bn(dh2048_p,sizeof(dh2048_p),NULL);
>      ^~
> proton-c/CMakeFiles/qpid-proton.dir/build.make:1102: recipe for target 
> 'proton-c/CMakeFiles/qpid-proton.dir/src/ssl/openssl.c.o' failed
> {code}
> The attached patch fixes this issue for 0.14.0 and also works for 0.16.0.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to