[
https://issues.apache.org/jira/browse/QPID-7629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Richardson updated QPID-7629:
-----------------------------------
Description:
See attached patch which applies this change to the NSS and SASL include
directories. The patch does not affect the included headers from perl, python,
ruby or boost since it is probably not necessary to consider those dependencies.
This change would prevent -Werror being applied to code in header files
included from dependent libraries, which can cause failures such as:
[ 25%] Building CXX object src/CMakeFiles/qpidcommon.dir/qpid/Modules.cpp.o
In file included from /usr/include/nss/ssl.h:18:0,
from
/var/tmp/portage/net-misc/qpid-cpp-1.36.0/work/qpid-cpp-1.36.0/src/qpid/sys/ssl/util.cpp:30:
/usr/include/nss/sslt.h:121:40: error: comma at end of enumerator list
[-Werror=pedantic]
ssl_sig_rsa_pkcs1_sha1md5 = 0x10101,
^
cc1plus: all warnings being treated as errors
was:
This change would prevent -Werror being applied to code in header files
included from dependent libraries, which can cause failures such as:
[ 25%] Building CXX object src/CMakeFiles/qpidcommon.dir/qpid/Modules.cpp.o
In file included from /usr/include/nss/ssl.h:18:0,
from
/var/tmp/portage/net-misc/qpid-cpp-1.36.0/work/qpid-cpp-1.36.0/src/qpid/sys/ssl/util.cpp:30:
/usr/include/nss/sslt.h:121:40: error: comma at end of enumerator list
[-Werror=pedantic]
ssl_sig_rsa_pkcs1_sha1md5 = 0x10101,
^
cc1plus: all warnings being treated as errors
> Use CMake "SYSTEM" keyword when including headers
> -------------------------------------------------
>
> Key: QPID-7629
> URL: https://issues.apache.org/jira/browse/QPID-7629
> Project: Qpid
> Issue Type: Improvement
> Components: C++ Broker, C++ Client
> Affects Versions: qpid-cpp-1.36.0
> Reporter: Chris Richardson
> Fix For: qpid-cpp-1.37.0
>
> Attachments: 1.36.0-system-includes.patch
>
>
> See attached patch which applies this change to the NSS and SASL include
> directories. The patch does not affect the included headers from perl,
> python, ruby or boost since it is probably not necessary to consider those
> dependencies.
> This change would prevent -Werror being applied to code in header files
> included from dependent libraries, which can cause failures such as:
> [ 25%] Building CXX object src/CMakeFiles/qpidcommon.dir/qpid/Modules.cpp.o
> In file included from /usr/include/nss/ssl.h:18:0,
> from
> /var/tmp/portage/net-misc/qpid-cpp-1.36.0/work/qpid-cpp-1.36.0/src/qpid/sys/ssl/util.cpp:30:
> /usr/include/nss/sslt.h:121:40: error: comma at end of enumerator list
> [-Werror=pedantic]
> ssl_sig_rsa_pkcs1_sha1md5 = 0x10101,
> ^
> cc1plus: all warnings being treated as errors
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
