[
https://issues.apache.org/jira/browse/QPID-7658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15851350#comment-15851350
]
Lorenz Quack commented on QPID-7658:
------------------------------------
You are right, in the HA case we could not share a single LinkRegistry.
I felt that because the localContainerId is part of the definition of the Link
it felt reasonable to pass it in.
Whether the implementation then actually uses it should not be the concern of
the interface.
But maybe you are right and this will never be useful.
> [Java Broker] Improve LinkRegistry
> ----------------------------------
>
> Key: QPID-7658
> URL: https://issues.apache.org/jira/browse/QPID-7658
> Project: Qpid
> Issue Type: Task
> Components: Java Broker
> Reporter: Lorenz Quack
> Fix For: qpid-java-7.0
>
>
> Currently the AbstractVirtualHost has a Map<remoteContainerId, LinkRegistry>.
> The handling of the remoteContainerId should also be encapsulated in the
> LinkRegistry giving each VH only a single LinkRegistry.
> Furthermore the following change to the LinkRegistry is proposed:
> * LinkRegistry.putSendingLinkIfAbsent(String localContainerId, String
> remoteContrainerId, String linkName, Source source, Target target) ->
> Pair<Source, Target>
> * LinkRegistry.putReceivingLinkIfAbsent(String localContainerId, String
> remoteContrainerId, String linkName, Source source, Target target) ->
> Pair<Source, Target>
> * LinkRegistry.getSendvingLink(String localContainerId, String
> remoteContrainerId, String linkName) -> Pair<Source, Target>
> * LinkRegistry.getReceivingLink(String localContainerId, String
> remoteContrainerId, String linkName) -> Pair<Source, Target>
> * LinkRegistry.removeSendingLink(String localContainerId, String
> remoteContrainerId, String linkName) -> Pair<Source, Target>
> * LinkRegistry.removeReceivingLink(String localContainerId, String
> remoteContrainerId, String linkName) -> Pair<Source, Target>
> The implementation of which must be thread-safe because the LinkRegistry will
> be accessed on multiple threads concurrently.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
