Github user ted-ross commented on a diff in the pull request:

    https://github.com/apache/qpid-dispatch/pull/143#discussion_r103750047
  
    --- Diff: src/server.c ---
    @@ -146,6 +148,26 @@ char *COMPONENT_SEPARATOR = ";";
     
     const char *DEFAULT_USER_ID = "anonymous";
     
    +const char *qd_log_message_components[] =
    --- End diff --
    
    You should move this out of server.c where it doesn't really belong.  
Consider adding a message_trace.[ch] module for this logic.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to