[ https://issues.apache.org/jira/browse/PROTON-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15935188#comment-15935188 ]
ASF GitHub Bot commented on PROTON-1408: ---------------------------------------- Github user astitcher commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/99#discussion_r107257116 --- Diff: proton-c/src/core/transport.c --- @@ -1619,6 +1619,17 @@ static int pn_scan_error(pn_data_t *data, pn_condition_t *condition, const char return 0; } +/* + This operator, copied from code for the qpid cpp broker, gives the correct + result when comparing sequence numbers implemented in a signed integer type. +*/ +static bool sequence_less_than ( pn_sequence_t a, pn_sequence_t b ) --- End diff -- ie code would be static int sequence_cmp(pn_sequence_t a, pn_sequence_t b) { return a-b; } > long-lived connections suffer large performance hit after many messages > ----------------------------------------------------------------------- > > Key: PROTON-1408 > URL: https://issues.apache.org/jira/browse/PROTON-1408 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c > Reporter: michael goulish > Assignee: Alan Conway > Attachments: jira_proton_1408_reproducer.tar.gz > > > In long-running soak tests, in which connections are never taken down, I am > seeing a sudden & severe performance degradation when the number of messages > over the connection reaches about 6.4 billion. > This is happening in tests with two senders, two receivers & one router > intermediating. > I have tried C libUV clients as well as CPP clients. Behavior is not > identical, but I see sudden performance drop, ie. 8x throughput decrease or > worse, in both cases. > Alan / Ted / Ken see an issue in use of improper comparison logic in > pn_do_disposition(), in transport.c . I am trying to prove this now. -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org