Github user gemmellr commented on a diff in the pull request:

    https://github.com/apache/qpid-jms/pull/10#discussion_r128750540
  
    --- Diff: 
qpid-jms-client/src/test/java/org/apache/qpid/jms/test/testpeer/TestAmqpPeer.java
 ---
    @@ -495,6 +512,169 @@ public void run()
             }
         }
     
    +    public void expectGSSAPIFail(Symbol mech) throws Exception {
    +        SaslMechanismsFrame saslMechanismsFrame = new 
SaslMechanismsFrame().setSaslServerMechanisms(mech);
    +
    +        addHandler(new HeaderHandlerImpl(AmqpHeader.SASL_HEADER, 
AmqpHeader.SASL_HEADER,
    +                new FrameSender(
    +                        this, FrameType.SASL, 0,
    +                        saslMechanismsFrame, null)));
    +
    +        addHandler(new SaslInitMatcher().withMechanism(equalTo(mech)));
    +
    +    }
    +
    +    public void expectGSSAPI(Symbol mech, String serviceName) throws 
Exception {
    --- End diff --
    
    Rename to expectSaslGSSAPI for consistency with the other sasl verification 
methods. Passing the mechanism name is perhaps also a bit redundant and could 
be removed. Similarly for the expectGSSAPIFail.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to