Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/qpid-jms/pull/10#discussion_r128810019
--- Diff:
qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/AmqpSaslAuthenticator.java
---
@@ -137,7 +142,9 @@ private void handleSaslStep() throws
JMSSecurityException {
byte[] challenge = new byte[sasl.pending()];
sasl.recv(challenge, 0, challenge.length);
byte[] response =
mechanism.getChallengeResponse(challenge);
- sasl.send(response, 0, response.length);
+ if (response != null) {
--- End diff --
Good point. Interesting, I guess it is allowing for the 'additional-data'
style information at the end of the exchange where there isn't a response.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
