[ https://issues.apache.org/jira/browse/QPID-7781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16118466#comment-16118466 ]
Alex Rudyy commented on QPID-7781: ---------------------------------- Keith, I reviewed the changes and here are my comments Changes committed under revision [ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=e697c9e ] look reasonable to me It seems more work is required for the commit under revision [ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=3e1ddbc ] * Add button "Add VH" into VHN tab. I intuitively was looking into VHN tab first to get to the Add VH UI but could not find it there. * Add Virtual Host widget ** dialog is not destroyed on pressing hide icon from dialog title. On every click on "Add VH" item followed by click hide title icon, a new instance of dialog is created with its own markup. I think adding a handler dialog.on("hide", function) should fix the issue. ** I doubt the need of field set in VH dialog markup for the form fields. There is only one field set, thus, fieldset group on form is redundant. ** commented code {{//this.addVirtualHost.hide(); // Seems to upset destroy??}} Does it meant that widget requires more work? ** destroy method: Do we really need to call domConstruct.destroy? ** onVhTypeChanged ui loading is asynchronous, thus, call to {{util.applyMetadataToWidgets(this.typeFields, "VirtualHost", type, metadata)}} might be invoked prematurelly. I think we need to change add.js for all virtual hosts to either return promise or call a callback passed as part of data parameter * context variable editor I would remove call to destroy on this.domNode or use domConstruct.destroy instead if it is required to delete dom node. > [Java Broker] 500 error whilst deleting a virtualhost. > ------------------------------------------------------ > > Key: QPID-7781 > URL: https://issues.apache.org/jira/browse/QPID-7781 > Project: Qpid > Issue Type: Bug > Components: Java Broker > Affects Versions: qpid-java-broker-7.0.0 > Reporter: Lorenz Quack > Assignee: Keith Wall > Fix For: qpid-java-broker-7.0.0 > > > The following 500 was encountered whilst deleting a JSON/Derby store backed > virtualhostnode/virtualhost. The virtualhost had three messages on two > queues. Clients were connected to the queues at the time (stopped on a > breakpoint). The Broker did not crash. > This will probably be just a trunk issue. > {noformat} > 2017-05-12 15:28:34,596 ERROR [HttpManagement-HTTP-89] > (o.a.q.s.m.p.f.ExceptionHandlingFilter) - Unexpected exception in servlet > '/api/latest/virtualhostnode': > java.lang.IllegalStateException: Message store is not open > at > org.apache.qpid.server.store.derby.AbstractDerbyMessageStore.checkMessageStoreOpen(AbstractDerbyMessageStore.java:117) > at > org.apache.qpid.server.store.derby.DerbyMessageStore.getConnection(DerbyMessageStore.java:57) > at > org.apache.qpid.server.virtualhost.derby.DerbyVirtualHostImpl.getConnection(DerbyVirtualHostImpl.java:111) > at > org.apache.qpid.server.protocol.v1_0.store.jdbc.JDBCLinkStore.getConnection(JDBCLinkStore.java:224) > at > org.apache.qpid.server.protocol.v1_0.store.jdbc.JDBCLinkStore.doDelete(JDBCLinkStore.java:189) > at > org.apache.qpid.server.protocol.v1_0.store.AbstractLinkStore.delete(AbstractLinkStore.java:122) > at > org.apache.qpid.server.protocol.v1_0.LinkRegistryImpl.delete(LinkRegistryImpl.java:136) > at > org.apache.qpid.server.virtualhost.AbstractVirtualHost$13.run(AbstractVirtualHost.java:2233) > at > org.apache.qpid.server.model.AbstractConfiguredObject$21.onSuccess(AbstractConfiguredObject.java:2587) > at > org.apache.qpid.server.model.AbstractConfiguredObject$22$1.run(AbstractConfiguredObject.java:2628) > at > org.apache.qpid.server.model.AbstractConfiguredObject$22$1.run(AbstractConfiguredObject.java:2624) > at java.security.AccessController.doPrivileged(Native Method) > at javax.security.auth.Subject.doAs(Subject.java:360) > at > org.apache.qpid.server.model.AbstractConfiguredObject$22.onSuccess(AbstractConfiguredObject.java:2623) > at com.google.common.util.concurrent.Futures$6.run(Futures.java:1319) > at > org.apache.qpid.server.configuration.updater.TaskExecutorImpl$ImmediateIfSameThreadExecutor.execute(TaskExecutorImpl.java:392) > at > org.apache.qpid.server.configuration.updater.TaskExecutorImpl.execute(TaskExecutorImpl.java:175) > at > com.google.common.util.concurrent.ExecutionList.executeListener(ExecutionList.java:156) > at > com.google.common.util.concurrent.ExecutionList.execute(ExecutionList.java:145) > at > com.google.common.util.concurrent.AbstractFuture.set(AbstractFuture.java:185) > at > com.google.common.util.concurrent.SettableFuture.set(SettableFuture.java:53) > at > org.apache.qpid.server.model.AbstractConfiguredObject$2$1.onSuccess(AbstractConfiguredObject.java:641) > at > org.apache.qpid.server.model.AbstractConfiguredObject$22$1.run(AbstractConfiguredObject.java:2628) > at > org.apache.qpid.server.model.AbstractConfiguredObject$22$1.run(AbstractConfiguredObject.java:2624) > at java.security.AccessController.doPrivileged(Native Method) > at javax.security.auth.Subject.doAs(Subject.java:360) > at > org.apache.qpid.server.model.AbstractConfiguredObject$22.onSuccess(AbstractConfiguredObject.java:2623) > at com.google.common.util.concurrent.Futures$6.run(Futures.java:1319) > at > org.apache.qpid.server.configuration.updater.TaskExecutorImpl$ImmediateIfSameThreadExecutor.execute(TaskExecutorImpl.java:392) > at > org.apache.qpid.server.configuration.updater.TaskExecutorImpl.execute(TaskExecutorImpl.java:175) > at > com.google.common.util.concurrent.ExecutionList.executeListener(ExecutionList.java:156) > at > com.google.common.util.concurrent.ExecutionList.execute(ExecutionList.java:145) > at > com.google.common.util.concurrent.AbstractFuture.set(AbstractFuture.java:185) > at > com.google.common.util.concurrent.SettableFuture.set(SettableFuture.java:53) > at > org.apache.qpid.server.model.AbstractConfiguredObject$5$4.onSuccess(AbstractConfiguredObject.java:808) > at > org.apache.qpid.server.model.AbstractConfiguredObject$5$4.onSuccess(AbstractConfiguredObject.java:804) > at > org.apache.qpid.server.model.AbstractConfiguredObject$22$1.run(AbstractConfiguredObject.java:2628) > at > org.apache.qpid.server.model.AbstractConfiguredObject$22$1.run(AbstractConfiguredObject.java:2624) > at java.security.AccessController.doPrivileged(Native Method) > at javax.security.auth.Subject.doAs(Subject.java:360) > at > org.apache.qpid.server.model.AbstractConfiguredObject$22.onSuccess(AbstractConfiguredObject.java:2623) > at com.google.common.util.concurrent.Futures$6.run(Futures.java:1319) > at > com.google.common.util.concurrent.MoreExecutors$DirectExecutor.execute(MoreExecutors.java:457) > at > com.google.common.util.concurrent.ExecutionList.executeListener(ExecutionList.java:156) > at > com.google.common.util.concurrent.ExecutionList.execute(ExecutionList.java:145) > at > com.google.common.util.concurrent.AbstractFuture.set(AbstractFuture.java:185) > at > org.apache.qpid.server.model.AbstractConfiguredObject$ChainedSettableFuture.set(AbstractConfiguredObject.java:2444) > at > org.apache.qpid.server.model.AbstractConfiguredObject$19$1.onSuccess(AbstractConfiguredObject.java:2499) > at > org.apache.qpid.server.model.AbstractConfiguredObject$22$1.run(AbstractConfiguredObject.java:2628) > at > org.apache.qpid.server.model.AbstractConfiguredObject$22$1.run(AbstractConfiguredObject.java:2624) > at java.security.AccessController.doPrivileged(Native Method) > at javax.security.auth.Subject.doAs(Subject.java:360) > at > org.apache.qpid.server.model.AbstractConfiguredObject$22.onSuccess(AbstractConfiguredObject.java:2623) > {noformat} -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org