Github user ted-ross commented on a diff in the pull request:

    https://github.com/apache/qpid-dispatch/pull/185#discussion_r132259033
  
    --- Diff: include/qpid/dispatch/router.h ---
    @@ -42,7 +42,8 @@ typedef enum {
         QD_TREATMENT_MULTICAST_ONCE   = 1,
         QD_TREATMENT_ANYCAST_CLOSEST  = 2,
         QD_TREATMENT_ANYCAST_BALANCED = 3,
    -    QD_TREATMENT_LINK_BALANCED    = 4
    +    QD_TREATMENT_LINK_BALANCED    = 4,
    +    QD_TREATMENT_LINK_FORBIDDEN   = 5
    --- End diff --
    
    This constant should not have "_LINK_" in it.  That implies that this is 
only for link-routing.  You should rename it "QD_TREATMENT_FORBIDDEN" because 
this feature is not relevant for link-routing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to