[ https://issues.apache.org/jira/browse/QPID-7869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16125765#comment-16125765 ]
Keith Wall edited comment on QPID-7869 at 8/14/17 3:29 PM: ----------------------------------------------------------- Further comment as discussed: # getCertificatesInternal/getCertificates are near duplicates. If we change {{FileTrustStore}} so that trustManagers and certificates are cached onOpen, the need for {{getCertificatesInternal}} disappears. # The text of the descriptions reads slightly awkwardly: ## TrustStore#CERTIFICATE_EXPIRY_WARN_PERIOD perhaps "The number of days before a certificate's expiry that certificate expiration warnings will be written to the log". ## TrustStore#CERTIFICATE_EXPIRY_CHECK_FREQUENCY perhaps "Period (in days) with which the Broker will repeat the certificate expiration warning'. was (Author: k-wall): Further comment as discussed: # getCertificatesInternal/getCertificates are near duplicates. If we change {{FileTrustStore}} so that trustManagers and certificates are cached onOpen, the need for {{getCertificatesInternal}} disappears. # The text of the descriptions reads slightly awkwardly: ## TrustStore#CERTIFICATE_EXPIRY_WARN_PERIOD perhaps "The number of days before a certificate's expiry that certificate expiration warnings will be written to the log". ## TrustStore#CERTIFICATE_EXPIRY_CHECK_FREQUENCY perhaps "Period (in days) with which the Broker will repeat the certificate expiration warning'. The number of days before a certificate expires that warnings willl certificate expire warnings will be produced n days The amount of notice given before a certificate expirations. The point in time (days The number of days before the certificate expiry date" + " to issue the operational log warning about the certificate expiry > [Java Broker] Truststore improvements > ------------------------------------- > > Key: QPID-7869 > URL: https://issues.apache.org/jira/browse/QPID-7869 > Project: Qpid > Issue Type: Improvement > Components: Java Broker > Reporter: Keith Wall > Assignee: Keith Wall > Fix For: qpid-java-broker-7.0.0 > > Attachments: > 0001-QPID-7869-Proof-of-concept-only-validate-the-trust-a.patch > > > The current TrustStore API requires some tidy up/improvements to allow an > operator to better manage certificate expiry. > # Currently the details of certificates contained within the store are not > exposed in a uniform manner. {#getCertificateDetails}} should be pulled up > and implemented by all truststore types. I suggest we standardise on the > form currently used by > {{ManagedPeerCertificateTrustStore#getCertificateDetails}} (i.e. the > List<CertificateDetails>). For the {{SiteSpecificTrustStore}} it should > return a singleton list. > # KeyStores currently warn the user certificate are about to expire via > operational log messages. TrustStores should implement the same feature. > # For SSL client authentication, we should have a 'strict mode' where the > {{validFrom}}/{{validTo}} date of the peer certificate is validated before > the connection is accepted. This will help users utilising self signed > certificate for client authentication purpose effectively managed certificate > expiration. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org