Github user chrisrichardson77 commented on a diff in the pull request:
https://github.com/apache/qpid-cpp/pull/10#discussion_r143968869
--- Diff: src/qpid/broker/Selector.cpp ---
@@ -108,7 +108,7 @@ MessageSelectorEnv::MessageSelectorEnv(const Message&
m) :
const Value MessageSelectorEnv::specialValue(const string& id) const
{
- Value v;
+ Value v = Value();
--- End diff --
The original version of this is correct and invokes the default constructor.
The new version is incorrect - it default-constructs a temporary which is
copied/moved/elided (depending on compiler version and standard) to v.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
