[
https://issues.apache.org/jira/browse/PROTON-1622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16215060#comment-16215060
]
Jiri Daněk commented on PROTON-1622:
------------------------------------
Strange it is not working for you. It works on travis, as can be seen from the
codecov.io page linked in the PR.
bq. no need for bin/python-m-coverage.sh, just call python directly with the
extra args from cmake.
I forgot about {{--}}, env.py was eating the -m option and not passing it on to
python... Will fix.
bq. suggest you disable valgrind automatically for Coverage builds - like you
did for the sanitizers.
I thought this is happening, will check.
{noformat}
option(ENABLE_VALGRIND "Use valgrind to detect run-time problems" ON)
if (ENABLE_VALGRIND)
if (NOT VALGRIND_EXE)
message(STATUS "Can't locate the valgrind command; no run-time error
detection")
elseif (CMAKE_BUILD_TYPE MATCHES "Coverage")
message(STATUS "Building for coverage analysis; no run-time error
detection")
{noformat}
bq. do you need lcov only or both lcov and gcov in travis? I don't know, just
checking if its deliberate or an oversight.
Only lcov. I added what was needed to run record-coverage.sh. Which is lcov
only. I looked at
https://github.com/codecov/example-cpp11-cmake/blob/master/.travis.yml, saw
that it essentially duplicates the preexisting record-coverage.sh and decided
to run that instead. It wastes some time on generating the html report, which
is then ignored...
> Add coverage reporting to CMake build
> -------------------------------------
>
> Key: PROTON-1622
> URL: https://issues.apache.org/jira/browse/PROTON-1622
> Project: Qpid Proton
> Issue Type: Improvement
> Components: proton-c
> Affects Versions: proton-c-0.18.0
> Reporter: Jiri Daněk
> Assignee: Justin Ross
> Priority: Minor
> Labels: patch, testing
> Fix For: proton-c-0.19.0
>
>
> This improvement is intended to cover
> * Reporting coverage from Python code
> * Upload of Python and C/C++ coverage data from Travis CI to codecov.io for
> easy viewing
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
