[ https://issues.apache.org/jira/browse/QPID-7646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16218312#comment-16218312 ]
Rob Godfrey commented on QPID-7646: ----------------------------------- So for [~k-wall]'s proposals for 7.0 I agree on 1. and 2. on 3. I don't have strong views - as in my above comment, I'm not sure how interesting it is to know which particular session the link to the transaction coordinator is on. For [~alex.rufous]'s proposals I can also agree on 1. ; for 2. I think we need to define what we mean by the oldest transaction - the oldest transaction opened on this session, or the oldest transaction on which this session has outstanding transactional work. For 3. I don't have strong views. 4. looks like something we could defer until after 7.0 > [Java Broker] fix AbstractAMQPSession#getLocalTransactionOpen to support > values > 1 > ----------------------------------------------------------------------------------- > > Key: QPID-7646 > URL: https://issues.apache.org/jira/browse/QPID-7646 > Project: Qpid > Issue Type: Bug > Components: Java Broker > Reporter: Lorenz Quack > Fix For: qpid-java-broker-7.0.0 > > > During the review of QPID-7633 it was noted: > bq. Why do we only return 0 or 1 from > AbstractAMQPSession#getLocalTransactionOpen. That seems wrong. > which was followed up by Rob: > bq. On getLocalTransactionOpen, I agree that looks very dodgy. In AMQP 0-x > the value will only be 0 or 1, but I'm not sure the implementation the we > have now is safe. I think the implementations will need to define this > properly (i.e. the calculation will need to be atomic, and the value may be > > 1 for AMQP 1.0 ) -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org