[ 
https://issues.apache.org/jira/browse/PROTON-1711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16282007#comment-16282007
 ] 

ASF GitHub Bot commented on PROTON-1711:
----------------------------------------

GitHub user RoddieKieley opened a pull request:

    https://github.com/apache/qpid-proton/pull/131

    PROTON-1711: SSL_IMPL none SASL_IMPL none build attempts to build c-s…

    …sl-tests and fails
    
    Added simple check to only build c-ssl-tests if SSL_IMPL was not none.
    
    NOTE: This simple change also exposes the fact that the python binding does 
not build with SSL_IMPL none and all other configuration variables default at 
the moment. I disabled the python binding for a successful build as I didn't 
need it at the moment.
    
    Should be addressed here or via separate issue?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/RoddieKieley/qpid-proton PROTON-1711

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/qpid-proton/pull/131.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #131
    
----
commit 84f2ae514606fb69e6f985f911d4a966c20fc75a
Author: circleci <circl...@mail.com>
Date:   2017-12-07T15:28:07Z

    PROTON-1711: SSL_IMPL none SASL_IMPL none build attempts to build 
c-ssl-tests and fails
    
    Added simple check to only build c-ssl-tests if SSL_IMPL was not none.

----


> SSL_IMPL none SASL_IMPL none build attempts to build c-ssl-tests and fails
> --------------------------------------------------------------------------
>
>                 Key: PROTON-1711
>                 URL: https://issues.apache.org/jira/browse/PROTON-1711
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: proton-c
>         Environment: Fedora 25
> OSX 10.11.6
>            Reporter: Roddie Kieley
>
> When building a default build via 'cmake ../qpid-proton' everything builds as 
> expected. However after using 'ccmake ../qpid-proton' and setting SSL_IMPL to 
> none we see:
> Fedora 25
> {code}
> .
> .
> .
> [ 76%] Linking C executable c-data-tests
> [ 76%] Built target c-data-tests
> [ 77%] Building C object proton-c/src/tests/CMakeFiles/c-ssl-tests.dir/ssl.c.o
> [ 77%] Linking C executable c-ssl-tests
> CMakeFiles/c-ssl-tests.dir/ssl.c.o: In function `test_ssl_protocols':
> /home/rkieley/LocalProjects/issues/PROTON-X/qpid-proton/proton-c/src/tests/ssl.c:29:
>  undefined reference to `pn_ssl_domain_set_protocols'
> /home/rkieley/LocalProjects/issues/PROTON-X/qpid-proton/proton-c/src/tests/ssl.c:31:
>  undefined reference to `pn_ssl_domain_set_protocols'
> /home/rkieley/LocalProjects/issues/PROTON-X/qpid-proton/proton-c/src/tests/ssl.c:33:
>  undefined reference to `pn_ssl_domain_set_protocols'
> /home/rkieley/LocalProjects/issues/PROTON-X/qpid-proton/proton-c/src/tests/ssl.c:36:
>  undefined reference to `pn_ssl_domain_set_protocols'
> /home/rkieley/LocalProjects/issues/PROTON-X/qpid-proton/proton-c/src/tests/ssl.c:37:
>  undefined reference to `pn_ssl_domain_set_protocols'
> CMakeFiles/c-ssl-tests.dir/ssl.c.o:/home/rkieley/LocalProjects/issues/PROTON-X/qpid-proton/proton-c/src/tests/ssl.c:38:
>  more undefined references to `pn_ssl_domain_set_protocols' follow
> collect2: error: ld returned 1 exit status
> proton-c/src/tests/CMakeFiles/c-ssl-tests.dir/build.make:95: recipe for 
> target 'proton-c/src/tests/c-ssl-tests' failed
> gmake[2]: *** [proton-c/src/tests/c-ssl-tests] Error 1
> CMakeFiles/Makefile2:2435: recipe for target 
> 'proton-c/src/tests/CMakeFiles/c-ssl-tests.dir/all' failed
> gmake[1]: *** [proton-c/src/tests/CMakeFiles/c-ssl-tests.dir/all] Error 2
> Makefile:140: recipe for target 'all' failed
> gmake: *** [all] Error 2
> [rkieley@i7t450s 6]$
> {code}
> OSX 10.11.6
> {code}
> .
> .
> .
> [ 76%] Building C object 
> proton-c/src/tests/CMakeFiles/c-engine-tests.dir/engine.c.o
> [ 76%] Linking C executable c-engine-tests
> [ 76%] Built target c-engine-tests
> [ 77%] Building C object proton-c/src/tests/CMakeFiles/c-ssl-tests.dir/ssl.c.o
> [ 77%] Linking C executable c-ssl-tests
> Undefined symbols for architecture x86_64:
>   "_pn_ssl_domain_set_protocols", referenced from:
>       _test_ssl_protocols in ssl.c.o
> ld: symbol(s) not found for architecture x86_64
> clang: error: linker command failed with exit code 1 (use -v to see 
> invocation)
> gmake[2]: *** [proton-c/src/tests/CMakeFiles/c-ssl-tests.dir/build.make:96: 
> proton-c/src/tests/c-ssl-tests] Error 1
> gmake[1]: *** [CMakeFiles/Makefile2:2436: 
> proton-c/src/tests/CMakeFiles/c-ssl-tests.dir/all] Error 2
> gmake: *** [Makefile:141: all] Error 2
> earth:153 rkieley$
> {code}
> Note that I also had disabled the bindings as well as set SASL_IMPL to none.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to