[ https://issues.apache.org/jira/browse/PROTON-1718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16297488#comment-16297488 ]
Robbie Gemmell commented on PROTON-1718: ---------------------------------------- The comments applied to both commits and not just the second. The Sasl API as originally intended for using proton as a byte level protocol engine, how proton was envisaged and proton-j is mostly used, does let you implement specific mechanisms and is being used to do so in various clients/brokers/etc (though it wont let you send multiple init frames as thats not intended by the protocol). The model provided by the Reactor, which some folks added much later, rather hides it away in a fashion that makes it very difficult to use in the originally intended way, hence my question around whether thats really what you are hitting, which seems likely from prior issues. As I say, perhaps a nicer approach can be found that doesn't leak the implementation details, or is more specific to the Reactor since thats whats causing the hassle. Alternatively perhaps something more general can be put together in concert with the existing transport layering (which is essentially all the sasl handling is) previously exposed via the TransportInternal interface to allow other transport tinkering in the reactor model. I'm heading off for the holidays now, so I won't be around for couple of weeks. > (Proton-J) Custom Sasl > ---------------------- > > Key: PROTON-1718 > URL: https://issues.apache.org/jira/browse/PROTON-1718 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-j > Affects Versions: proton-j-0.24.0 > Reporter: Tim Taylor > Labels: features > > I would like to be able to provide a custom SASL implementation for Proton-j > to use instead of being forced to use the default SaslImpl.java > implementation. > Ideally, code like below would be possible > private class CustomSasl implements org.apache.qpid.proton.engine.Sasl > { > ... > } > ... > ... > //transport.sasl(...) saves the provided sasl implementation and uses it > internally > Sasl sasl = transport.sasl(new CustomSasl()); > Do you currently have a workaround that would allow me to use Proton-J this > way? -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org