Github user ganeshmurthy commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/237#discussion_r158114523
--- Diff: src/router_node.c ---
@@ -912,7 +913,7 @@ static void AMQP_opened_handler(qd_router_t *router,
qd_connection_t *conn, bool
strcmp(sym.start, QD_CONNECTION_PROPERTY_FAILOVER_PORT_KEY) == 0) {
pn_data_next(props);
if (pn_data_type(props) ==
PN_STRING) {
--- End diff --
since qdpn_data_as_string returns anything as string, the if check is not
required -
if (pn_data_type(props) == PN_STRING) {
}
should be removed
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
