[
https://issues.apache.org/jira/browse/DISPATCH-872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16300312#comment-16300312
]
ASF GitHub Bot commented on DISPATCH-872:
-----------------------------------------
Github user ganeshmurthy commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/226#discussion_r158332552
--- Diff: tests/system_tests_one_router.py ---
@@ -1552,6 +1552,14 @@ def check_if_done(self):
self.conn.close()
elif self.n_sent == self.n_released:
self.error = None
+
+ if not self.error:
--- End diff --
Yes, the if statement is unnecessary. It should be removed.
It is true that the test does not send pre-settled deliveries.
The router has allowUnsettledMulticast: yes
in this specific case we send an unsettled multicast to the router. But
there is no receiver, so the router sends back the following to the client -
[0x7ffb1c014c50]:0 -> @disposition(21) [role=true, first=0, last=0,
settled=true, state=@released(38) []]
Hence this delivery can be considered a dropped pre-settled?
https://github.com/apache/qpid-dispatch/blob/master/src/router_core/transfer.c#L783
> Add a counter for dropped-presettleds on links
> ----------------------------------------------
>
> Key: DISPATCH-872
> URL: https://issues.apache.org/jira/browse/DISPATCH-872
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Router Node
> Reporter: Ted Ross
> Assignee: Ganesh Murthy
> Fix For: 1.1.0
>
>
> When the router drops pre-settled deliveries during congestion, those drops
> are not counted or reported. A new counter should be added for links to
> account for dropped presettled deliveries.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
