[ 
https://issues.apache.org/jira/browse/QPID-7153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16483705#comment-16483705
 ] 

Keith Wall commented on QPID-7153:
----------------------------------

One comment.  If as a user I want the expired messages that that land on the 
DLQ to live indefinitely, then I would have expected to set the the DLQ's 
{{minimumMessageTtl}} to {{Long.MAX_VALUE}}.   This doesn't work because the 
long arithmetic overflows within {{AbstactQueue#calculateExpiration}} and 
{{wouldExpire}} (which would be better named wouldExpireNow) returns the wrong 
value.   Perhaps {{calculateExpiration}} should use {{Math.addExact}} and clamp 
the value if ArithmeticException occurs. 

Separately, largely note to self, when testing this feature with the Qpid JMS 
Client, one needs to remember to turn off {{jms.localMessageExpiry}} otherwise 
the client expires the message as it is consumed from the DLQ.

> Allow expired messages to be sent to DLQ
> ----------------------------------------
>
>                 Key: QPID-7153
>                 URL: https://issues.apache.org/jira/browse/QPID-7153
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Broker-J
>            Reporter: Keith Wall
>            Priority: Major
>         Attachments: QPID-7153v2.diff
>
>
> Currently the Java Broker simply discards messages that expire (TTL). The 
> behaviour should be configurable and allow for expired messages to be 
> directed to the alternate exchange to allow for dead-lettering.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to