[ 
https://issues.apache.org/jira/browse/QPID-8202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16504028#comment-16504028
 ] 

Keith Wall commented on QPID-8202:
----------------------------------

Isn't 6.1 affected by this problem too?  I haven't run the code but it looks 
like this problem has been with Broker-J since QPID-6953.

Your code change looks functionally correct to me, but the code remains less 
than obvious.

# It seems odd to give the {{MessageContentSourceBody}} all the {{content}}, 
{{offset}} and {{length}} only then to have {{#writePayload}} take a view a few 
moments later.  Passing  {{MessageContentSourceBody}} the view it needs would 
be an improvement.  Or perhaps replace {{MessageContentSourceBody}} with a 
{{ContentBody}} (and remember to call dispose)?
# The  calculation of {{capacity}} (which would be better named 
{{contentChunkSize}}) is weird and could be expressed more clearly.

 

> [Broker-J][AMQP 0-9] Large flowed to disk message can be re-loaded from store 
> for every content chunk sent to the client
> ------------------------------------------------------------------------------------------------------------------------
>
>                 Key: QPID-8202
>                 URL: https://issues.apache.org/jira/browse/QPID-8202
>             Project: Qpid
>          Issue Type: Bug
>          Components: Broker-J
>    Affects Versions: qpid-java-broker-7.0.3, qpid-java-broker-7.0.2, 
> qpid-java-broker-7.0.0, qpid-java-broker-7.0.1, qpid-java-broker-7.0.4
>            Reporter: Alex Rudyy
>            Assignee: Alex Rudyy
>            Priority: Critical
>             Fix For: qpid-java-broker-7.1.0, qpid-java-broker-7.0.5
>
>
> When large message cannot fit in one frame it is sent in multiple blocks. 
> Currently, the flowed to disk message is reloaded from store and evicted from 
> memory on sending every block. As result, the message consumption performance 
> is very slow. Only AMQP  protocols 0-8..0-91 are affected by the issue



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to