Github user ted-ross commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/328#discussion_r198605509 --- Diff: src/router_node.c --- @@ -312,12 +307,30 @@ static void AMQP_rx_handler(void* context, qd_link_t *link) pn_link_name(pn_link)); } + // + // The entire message has been received and we are ready to consume the delivery by calling pn_link_advance(). + // + pn_link_advance(pn_link); + + // + // The entire message has been received but this message needs to be discarded + // + if (qd_message_is_discard(msg)) { + pn_delivery_update(pnd, qdr_delivery_disposition(delivery)); --- End diff -- Is the delivery disposition _always_ set when discard is set? What if the disposition was not set? I think the pn_delivery_update should not be called in this case.
--- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org