[
https://issues.apache.org/jira/browse/PROTON-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16572809#comment-16572809
]
Jens Reimann commented on PROTON-1911:
--------------------------------------
Sorry, I have to correct myself with proton-j 0.22 .. it was actually proton-j
0.25 that I tested first. Between 0.25 and 0.28 I didn't see any difference.
We will be happy to use vertx 3.6.0 one it is releases. And thanks for the info
around the body part. I just looked up the way Hono actually does it, and I
think there is room for improvement.
But I also do think that this PR still kicks in with all the other strings, set
in all the properties. It will definitely boost performance.
> Performance issue in EncoderImpl#writeRaw(String)
> -------------------------------------------------
>
> Key: PROTON-1911
> URL: https://issues.apache.org/jira/browse/PROTON-1911
> Project: Qpid Proton
> Issue Type: Improvement
> Components: proton-j
> Affects Versions: proton-j-0.25.0, proton-j-0.28.0
> Reporter: Jens Reimann
> Priority: Major
> Labels: pull-request-available
> Attachments: qpid_encode_1.png, qpid_encode_2.png, qpid_encode_3.png,
> qpid_encode_4.png, strings_encode_after.json, strings_encode_before.json
>
>
> While digging into performance issues in the Eclipse Hono project I noticed a
> high consumption of CPU time when encoding AMQP messages using proton-j.
> I made a small reproducer and threw the same profiler at it, here are the
> results:
> As you can see in the attach screenshot (the first is the initial run with
> the current code) most of the time is consumed in
> EncoderImpl#writeRaw(String). This due to the fact that is call "put" for
> every byte it want to encode.
> The following screenshots are from a patched version which uses a small
> thread local buffer to locally encode the raw data and then flush it to the
> buffer in bigger chunks.
> Screenshot 3 and 4 show the improve performance, but also show that the
> memory consumption stays low.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
