[
https://issues.apache.org/jira/browse/DISPATCH-1098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16575279#comment-16575279
]
ASF GitHub Bot commented on DISPATCH-1098:
------------------------------------------
GitHub user ChugR opened a pull request:
https://github.com/apache/qpid-dispatch/pull/355
DISPATCH-1098: Adjust name of unit2 executable for python3
CMake chooses between 'python' and 'python3'.
Make a similar choice for 'unit2' and 'unit2-3'.
This lets both python2 and python3 versions to be installed on a system and
chooses between them based on the result of PYTHON_VERSING_MAJOR.
Tested on Fedora only.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ChugR/qpid-dispatch DISPATCH-1098
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/qpid-dispatch/pull/355.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #355
----
commit fdefed692a8c5a520aebcb0f16551ac0ee92858e
Author: Chuck Rolke <crolke@...>
Date: 2018-08-09T19:00:34Z
DISPATCH-1098: Adjust name of unit2 executable for python3
----
> Fedora 28 python3-only test issues
> ----------------------------------
>
> Key: DISPATCH-1098
> URL: https://issues.apache.org/jira/browse/DISPATCH-1098
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Tests
> Affects Versions: 1.2.0
> Reporter: Chuck Rolke
> Priority: Major
> Attachments: Dockerfile-DISPATCH-1098, build-1098.sh, run-1098.sh
>
>
> Building a Fedora 28, python-3-only (no python 2), proton and dispatch leads
> to some test issues.
> * `which python` is empty
> * `which unit2` is empty
> h4. Define python
> CMake finds python OK and builds proton and dispatch with the correct python
> version. But the tests don't work. _python_ appears to be a python 2
> construct. In a python 3 system the executable is installed as python3.
> Python can be defined with the alternatives command
> {{alternatives --install /usr/bin/python python /usr/bin/python3 1}}
> h4. Define unit2
> The self test runner in dispatch expects an executable named _unit2_. _Unit2_
> is a python 2 executable and in python 3 the equivalent program is named
> _unit2-3_. The dispatch build scheme should always use _unit2_ and thiis can
> be accomplished for python 3 with:
> {{alternatives --install /usr/bin/unit2 unit2 /usr/bin/unit2-3 1}}
> h4. Proposal
> Dispatch self test should use naked _python_ and _unit2_ commands. An check
> in the dispatch build could disable tests and warn about them being disabled
> similar to how a missing unittest2 is handled. See
> https://issues.apache.org/jira/browse/DISPATCH-919
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
