Github user ted-ross commented on a diff in the pull request:

    https://github.com/apache/qpid-dispatch/pull/357#discussion_r209295809
  
    --- Diff: include/qpid/dispatch/router_core.h ---
    @@ -797,4 +799,9 @@ qdr_connection_info_t *qdr_connection_info(bool         
    is_encrypted,
                                                int              ssl_ssf,
                                                bool             ssl);
     
    +typedef struct qdr_timer_work_t qdr_timer_work_t;
    +typedef void (*qdr_timer_cb_t)(qdr_core_t *core, void* context);
    +qdr_timer_work_t *qdr_timer_schedule(qdr_core_t *core, qdr_timer_cb_t 
callback, void *timer_context, int timer_delay);
    +void qdr_timer_delete(qdr_core_t *core, qdr_timer_work_t *timer_work);
    --- End diff --
    
    Some comments on these function prototypes would be helpful?  What exactly 
does qdr_timer_delete do?  Should there be a qdr_timer_cancel()?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to