GitHub user matlo607 opened a pull request:
https://github.com/apache/qpid-proton/pull/154
Replace user-defined macro WIN32 by compiler-defined _WIN32
On Windows, if qpid-proton is used by another build system (still compiling
with VC) than a Visual Studio project, `/D WIN32` is not automatically set on
the command line.
Today both `WIN32` and `_WIN32` can be found in the source code.
The idea here are:
* removing this uncertainty by using `_WIN32` that is automatically set by
the compiler
* having a better uniformity across the source code.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/matlo607/qpid-proton replace-WIN32-by-_WIN32
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/qpid-proton/pull/154.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #154
----
commit ee3484bc506e098932de7963426d71837b98b8a7
Author: Matthieu Longo <mateo.longo@...>
Date: 2018-08-22T13:53:01Z
Replace user-defined macro WIN32 by compiler-defined _WIN32
More information are available at
https://stackoverflow.com/questions/662084/whats-the-difference-between-the-win32-and-win32-defines-in-c
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
