[jira] [Commented] (DISPATCH-1116) qdmanage lets the module of log instance be changed

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/DISPATCH-1116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16606309#comment-16606309
 ] 

ASF GitHub Bot commented on DISPATCH-1116:
------------------------------------------

Github user codecov-io commented on the issue:

    https://github.com/apache/qpid-dispatch/pull/372
  
    # 
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/372?src=pr&el=h1) 
Report
    > Merging 
[#372](https://codecov.io/gh/apache/qpid-dispatch/pull/372?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/qpid-dispatch/commit/eb766e3ade97b4ee5bca0b21ebe7403a8317d6e9?src=pr&el=desc)
 will **increase** coverage by `0.07%`.
    > The diff coverage is `n/a`.
    
    [![Impacted file tree 
graph](https://codecov.io/gh/apache/qpid-dispatch/pull/372/graphs/tree.svg?width=650&token=rk2Cgd27pP&height=150&src=pr)](https://codecov.io/gh/apache/qpid-dispatch/pull/372?src=pr&el=tree)
    
    ```diff
    @@            Coverage Diff             @@
    ##           master     #372      +/-   ##
    ==========================================
    + Coverage   84.79%   84.86%   +0.07%     
    ==========================================
      Files          70       70              
      Lines       16004    16003       -1     
    ==========================================
    + Hits        13570    13581      +11     
    + Misses       2434     2422      -12
    ```
    
    
    | [Impacted 
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/372?src=pr&el=tree) | 
Coverage Δ | |
    |---|---|---|
    | 
[src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/372/diff?src=pr&el=tree#diff-c3JjL2NvbnRhaW5lci5j)
 | `76.55% <0%> (-0.2%)` | :arrow_down: |
    | 
[src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/372/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=)
 | `93.86% <0%> (+0.25%)` | :arrow_up: |
    | 
[src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/372/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=)
 | `90.44% <0%> (+0.45%)` | :arrow_up: |
    | 
[src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/372/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=)
 | `93.64% <0%> (+0.76%)` | :arrow_up: |
    | 
[src/router\_core/core\_timer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/372/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2NvcmVfdGltZXIuYw==)
 | `96.42% <0%> (+1.78%)` | :arrow_up: |
    
    ------
    
    [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/372?src=pr&el=continue).
    > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
    > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
    > Powered by 
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/372?src=pr&el=footer).
 Last update 
[eb766e3...6c34481](https://codecov.io/gh/apache/qpid-dispatch/pull/372?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).



> qdmanage lets the module of log instance be changed
> ---------------------------------------------------
>
>                 Key: DISPATCH-1116
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-1116
>             Project: Qpid Dispatch
>          Issue Type: Bug
>            Reporter: Gordon Sim
>            Assignee: Gordon Sim
>            Priority: Major
>             Fix For: 1.4.0
>
>
> E.g. 
> {noformat}
> $ qdmanage update --type=log --name=log/ROUTER module=SERVER enable=trace+
> {
>   "enable": "trace+", 
>   "type": "org.apache.qpid.dispatch.log", 
>   "identity": "log/ROUTER", 
>   "module": "SERVER", 
>   "name": "log/AUTHSERVICE"
> }
> {noformat}
> This seems unnecessary and likely to cause problems.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org