[
https://issues.apache.org/jira/browse/QPID-8245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16627301#comment-16627301
]
Alex Rudyy edited comment on QPID-8245 at 9/25/18 1:00 PM:
-----------------------------------------------------------
Attached patches:
* 0001-QPID-8245\-Broker-J-Stop-rellocating-message-headers-.patch ; the patch
refactors {{BasicContentHeaderProperties}} to stop reallocating headers byte
buffer and re-creates the {{FieldTable}} after relocation of
{{BasicContentHeaderProperties}} buffer. I think this work requires a separate
JIRA.
* 0002-QPID-8245\-Add-factory-methods-to-create-field-table-.patch; the patch
adds some factory methods into {{FieldTableFactory}} and replaces calls to
{{FieldTable}} constructors with factory methods
* 0003-QPID-8245-Remove-FiledTable-setters-methods-modifyin.patch; the patch
removes setters, methods modifying {{FieldTable}} and bunch of deprecated and
unused methods
* 0004-QPID-8245-Decode-field-table-properties-when-require.patch; the patch
adds functionality to decode fields on demand
* 0005-QPID-8245-Split-field-table-into-2-implementations.patch; the patch
converts {{FieldTable}} into interface and introduces 2 implementations
Rob,
Please feel free to disregard my patches and commit your changes
was (Author: alex.rufous):
Attached patches:
* 0001-QPID-8245-Broker-J-Stop-rellocating-message-headers-.patch ; the patch
refactors {{BasicContentHeaderProperties}} to stop reallocating headers byte
buffer and re-creates the {{FieldTable}} after relocation of
{{BasicContentHeaderProperties}} buffer. I think this work requires a separate
JIRA.
* 0002-QPID-8245-Add-factory-methods-to-create-field-table-.patch; the patch
adds some factory methods into {{FieldTableFactory}} and replaces calls to
{{FieldTable}} constructors with factory methods
* 0003-QPID-8245-Remove-FiledTable-setters-methods-modifyin.patch; the patch
removes setters, methods modifying {{FieldTable}} and bunch of deprecated and
unused methods
* 0004-QPID-8245-Decode-field-table-properties-when-require.patch; the patch
adds functionality to decode fields on demand
* 0005-QPID-8245-Split-field-table-into-2-implementations.patch; the patch
converts {{FieldTable}} into interface and introduces 2 implementations
Rob,
Please feel free to disregard my patches and commit your changes
> [Broker-J] [AMQP 0-8..0-91] Decode FiledTable fields on demand
> --------------------------------------------------------------
>
> Key: QPID-8245
> URL: https://issues.apache.org/jira/browse/QPID-8245
> Project: Qpid
> Issue Type: Improvement
> Components: Broker-J
> Affects Versions: qpid-java-broker-7.1.0
> Reporter: Alex Rudyy
> Priority: Major
> Fix For: qpid-java-broker-7.1.0
>
> Attachments:
> 0001-QPID-8245-Broker-J-Stop-rellocating-message-headers-.patch,
> 0002-QPID-8245-Add-factory-methods-to-create-field-table-.patch,
> 0003-QPID-8245-Remove-FiledTable-setters-methods-modifyin.patch,
> 0004-QPID-8245-Decode-field-table-properties-when-require.patch,
> 0005-QPID-8245-Split-field-table-into-2-implementations.patch
>
>
> At the moment all field table properties are decoded when decode
> functionality is invoked. For use cases when only some of the field table
> properties are queried, the decoding functionality can be changed to stop
> decoding on getting the requested property. Potentially, such approach can
> improve the performance of routing transient messages when destinations are
> bound to the routing exchange using selector filters. As filter expression
> contains only some properties, the decoding of message headers can be stopped
> on getting all fields specified in selector expression.
> The idea is illustrated by Rob Godfrey on
> [QPID-8238|https://issues.apache.org/jira/browse/QPID-8238?focusedCommentId=16601936&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16601936]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
