[
https://issues.apache.org/jira/browse/QPID-7372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16627714#comment-16627714
]
ASF GitHub Bot commented on QPID-7372:
--------------------------------------
Github user rgodfrey commented on the issue:
https://github.com/apache/qpid-broker-j/pull/13
The scope of QPID-7372 was to remove the dependency on logback from the
broker-core module, so it's not correct to say that "it hasn't been fully
fixed" - the class you are modifying here is not in broker-core, but "broker".
The "broker" module is expected to have specific dependencies (it essentially
provides a specific implementation for starting the broker) that are left open
in broker-core.
As you can see, on master this code has changed around a bit now with a
slightly better separation of the logic between broker and broker-core (IMHO).
Since 6.1.x is essentially in maintenance only, and the relevant area has
changed for 7.x and beyond I don't think it makes sense to try to apply changes
here
> [Java Broker] Remove hard dependency on logback from broker-core
> ----------------------------------------------------------------
>
> Key: QPID-7372
> URL: https://issues.apache.org/jira/browse/QPID-7372
> Project: Qpid
> Issue Type: Improvement
> Components: Broker-J
> Reporter: Rob Godfrey
> Assignee: Rob Godfrey
> Priority: Major
> Fix For: qpid-java-6.1
>
>
> Currently the SystemConfig class has a hard dependency on LogBack, and forces
> instantiation / resetting the logback config.
> To allow for easier embedding of the broker we can move this instantiation
> out of the core model and into the code use to bootstrap the broker instance.
> We can also move the logback dependent model objects into a separate plugin.
> In this way the System Config (and child Broker) will simply use whatever
> has been set up for them in slf4j and an embedder of the broker could choose
> to use a different logging provider or supply a logback configuration which
> is not managed by the broker itself.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
