[
https://issues.apache.org/jira/browse/PROTON-576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16649960#comment-16649960
]
ASF GitHub Bot commented on PROTON-576:
---------------------------------------
GitHub user jdanekrh opened a pull request:
https://github.com/apache/qpid-proton-j/pull/17
NO-JIRA: Undo PROTON-576: update test to make it compile on Java 6
Since PROTON-1913, the Java version required by proton-j is 8+.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jdanekrh/qpid-proton-j jd_java8
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/qpid-proton-j/pull/17.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #17
----
commit a3ad70767d295cdf343d13a86cee431f510b2134
Author: Jiri Danek <jdanek@...>
Date: 2018-10-13T11:30:33Z
NO-JIRA: Undo PROTON-576: update test to make it compile on Java 6
Since PROTON-1913, the Java version required by proton-j is 8+.
----
> proton-j: codec support for UTF-8 encoding and decoding appears broken?
> -----------------------------------------------------------------------
>
> Key: PROTON-576
> URL: https://issues.apache.org/jira/browse/PROTON-576
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-j
> Affects Versions: 0.7
> Reporter: Dominic Evans
> Priority: Major
> Fix For: 0.8
>
> Attachments: 02_fix_stringtype_encode_decode.patch, PROTON-576.patch
>
>
> It seems like Proton-J has its own custom UTF-8 encoder, but relies on Java
> String's built-in UTF-8 decoder. However, the code doesn't seem quite right
> and complex double byte UTF-8 like emoji ('📔🚢🍛🍴🍹🏊🏄') can quite easily fail to
> parse:
> | | Cause:1 :- java.lang.IllegalArgumentException: Cannot parse
> String
> | | Message:1 :- Cannot parse String
> | | StackTrace:1 :- java.lang.IllegalArgumentException: Cannot parse
> String
> | | at
> org.apache.qpid.proton.codec.StringType$1.decode(StringType.java:48)
> | | at
> org.apache.qpid.proton.codec.StringType$1.decode(StringType.java:36)
> | | at
> org.apache.qpid.proton.codec.DecoderImpl.readRaw(DecoderImpl.java:945)
> | | at
> org.apache.qpid.proton.codec.StringType$AllStringEncoding.readValue(StringType.java:172)
> | | at
> org.apache.qpid.proton.codec.StringType$AllStringEncoding.readValue(StringType.java:124)
> | | at
> org.apache.qpid.proton.codec.DynamicTypeConstructor.readValue(DynamicTypeConstructor.java:39)
> | | at
> org.apache.qpid.proton.codec.DecoderImpl.readObject(DecoderImpl.java:885)
> | | at
> org.apache.qpid.proton.message.impl.MessageImpl.decode(MessageImpl.java:629)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
